[Solved] For Triggers triggered on a timer, how do you get the player index - Triggers - Development - SC2 Mapster Forums

#1 Jan 19, 2013

_ForgeUser7263139

Join Date: 7/25/2011
Posts: 30
Member Details

Hi all! Having some problems with a 2 player map I'm working on. Here's where I'm getting stuck...

Write vespene collected/current count every time it changes
    Events
        Player - Player (Triggering player) Vespene changes 
    Local Variables
    Conditions
    Actions
        Bank - Open bank "vespeneBank" for player (Triggering player)
        Bank - Store integer (Player (Triggering player) Vespene) as "current_vespense_count" of section "data" in bank (Last opened bank)
        Bank - Store integer (Player (Triggering player) Vespene Collected) as "total_vespene_collected" of section "data" in bank (Last opened bank)
        Bank - Save bank (Last opened bank)

This trigger works great because I'm able to use the (Triggering player) in the Actions because the event that triggers this is a player's vespene count changes.

When I'm trying to record some attribute about the player every X seconds like APM:

Write APM to every 1 second
    Events
        Timer - Every 1.0 seconds of Game Time
    Local Variables
        playerAPM = (Player 1 APM score) <Integer>
    Conditions
    Actions
        Bank - Open bank "apmBank" for player 1
        Bank - Store integer playerAPM as "player_apm" of section "data" in bank (Last opened bank)
        Bank - Save bank (Last opened bank)

I don't have a notion of (Triggering player) anymore so I'm forced to use Player 1 APM score to get the APM and then player 1 to get the bank. This will record data on Player 1's computer, but Player 2's data won't be saved unless I make another trigger or duplicate some code to also get their APM.

Is there any way around this Timer-triggered events/getting access to the player index? I don't particularly care about player indices in this case and I don't want to have 2 version of every trigger. Am I missing something obvious?

Thanks in advance for the help!

EDIT: Here's the most "concise" solution I can come up with:

Write APM to every 1 second
    Events
        Timer - Every 1.0 seconds of Game Time
    Local Variables
        player1APM = (Player 1 APM score) <Integer>
        player2APM = (Player 2 APM score) <Integer>
    Conditions
    Actions
        Bank - Open bank "apmBank" for player 1
        Bank - Store integer player1APM as "player_apm" of section "data" in bank (Last opened bank)
        Bank - Save bank (Last opened bank)
        ------- TODO: make this more concise if possible by eliminating player index
        Bank - Open bank "apmBank" for player 2
        Bank - Store integer player2APM as "player_apm" of section "data" in bank (Last opened bank)
        Bank - Save bank (Last opened bank)

Once I learn how to write share-able modules, this probably won't look to bad, but is there a better way?

Last edited by _ForgeUser7263139: Jan 19, 2013

#2 Jan 19, 2013

_ForgeUser6627554

Join Date: 4/4/2011
Posts: 1,180
Member Details

"For each player in player group" is a loop that can iterate over all active players storing their player number in a variable.

Also, you would want to save bank variables in an array with the player number as its index. Then you can always save the value in the correct bank.

#3 Jan 20, 2013

_ForgeUser7263139

Join Date: 7/25/2011
Posts: 30
Member Details

@Ahli634: Go

Thank you for the reply! I think I got the first part of your recommendation working!

Write APM to every 1 second
    Events
        Timer - Every 1.0 seconds of Game Time
    Local Variables
        i = 0 <Integer>
        playerAPM = (Player i APM score) <Integer>
    Conditions
    Actions
        Player Group - For each player i in (All players) do (Actions)
            Actions
                Variable - Set playerAPM = (Player i APM score)
                Bank - Open bank "apmBank" for player i
                Bank - Store integer playerAPM as "player_apm" of section "data" in bank (Last opened bank)
                Bank - Save bank (Last opened bank)

What would the bank code you described look like generally? Is what I'm doing now not correct or just not recommended/standard?

Thank you!

#4 Jan 20, 2013

Jman1177

Curse Premium

Join Date: 7/16/2010
Posts: 4,334
Member Details

The "Standard" banking procedure would be something like this:

At the start of the map this is run once:

Preload & Synchronize Bank "MyBank" for player 1
Open Bank "MyBank" for player 1
Set variable Banks[1] to (Last Created Bank)
Preload & Synchronize Bank "MyBank" for player 2
Open Bank "MyBank" for player 2
Set variable Banks[2] to (Last Created Bank)
Preload & Synchronize Bank "MyBank" for player 3
Open Bank "MyBank" for player 3
Set variable Banks[3] to (Last Created Bank)
(Etc, etc, repeat for all players. Do not use a loop).

You only need to open your banks once ever during the map. So your script would look like this now:

Write APM to every 1 second
    Events
        Timer - Every 1.0 seconds of Game Time
    Local Variables
        i = 0 <Integer>
        playerAPM = (Player i APM score) <Integer>
    Conditions
    Actions
        Player Group - For each player i in (All players) do (Actions)
            Actions
                Variable - Set playerAPM = (Player i APM score)
                Bank - Store integer playerAPM as "player_apm" of section "data" in bank Banks[i]
                Bank - Save bank Banks[i]

Now that you've got your banks stored in an array variable, you can very easily reference them in the future. Bank[1] is player 1's bank, bank[7] would be player 7's bank, etc... Using the "Last created/destroyed/opened/used whatever" functions is generally something I advise against, except of course when using it immediately after the corresponding action to something to assign a variable. You just tend to run into less issues that way (using the "last created" functions is not a problem itself, but improperly using them will result in issues).

In the case of banks I advise people use to use variables like this to keep things clean and organized, but again, the trigger you have now looks totally fine.

Feel free to Send me a PM if you have any questions/concerns!